moved GLOBAL, SESSION, and VARIABLES to non_reserved_keyword#3585
Merged
sougou merged 2 commits intovitessio:masterfrom Jan 25, 2018
slanning:non-reserved-keywords2
Merged
moved GLOBAL, SESSION, and VARIABLES to non_reserved_keyword#3585sougou merged 2 commits intovitessio:masterfrom slanning:non-reserved-keywords2
sougou merged 2 commits intovitessio:masterfrom
slanning:non-reserved-keywords2
Conversation
Contributor
|
In terms of your question around GLOBAL and SESSION, the general rule of thumb is to try So if you're wondering I'd try moving GLOBAL/SESSION to |
Contributor
Author
|
Thanks for the feedback. I'll try that tomorrow. (I did have a shift-reduce conflict when making the original change, and it's quite possible that putting it in reserved_keyword is just a relic of an attempt at resolving that...) |
Didn't cause shift-reduce conflicts.
slanning
changed the title
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes an omission from b61debd
to remove the extra STATUS left in reserved_keyword .
I wasn't sure about GLOBAL and SESSION from my previous commit e5655b8 ,
so I left them for now but possibly they also should be in non_reserved_keyword.
(This is a second attempt at my botched PR #3577 ...)